Use transposed size after opening for TIFF images #8390

radarhere · 2024-09-18T10:43:29Z

Alternative to #8387

At the moment, load() might change the size of a TIFF image, since TIFF images are automatically transposed when doing so.

load() is a method that many users are probably not even aware of, and so they might find

from PIL import Image
im = Image.open("/Users/andrewmurray/pillow/Pillow/Tests/images/g4_orientation_5.tif")
print(im.size)  # (88, 590)
print(im.copy().size)  # (590, 88)

unexpected.

After this PR, the first im.size will also be (590, 88). This has means that changes from #6186 and #6190 can be removed.

#8387 solves this by making im.size sometimes different to im._size. I would like to avoid that, and have instead found a solution by adding TiffImageFile.load_prepare().

While we are here streamlining things so that an image does not change its size after loading, I've also updated ImageFile to remove an implication that loading might change an image's mode.

homm · 2024-09-18T11:12:03Z

src/PIL/ImageFile.py

@@ -322,7 +322,7 @@ def load(self) -> Image.core.PixelAccess | None:

    def load_prepare(self) -> None:
        # create image memory if necessary
-        if self._im is None or self.im.mode != self.mode or self.im.size != self.size:


Not sure how it affects multipage images with different page sizes

When seeking to a different TIFF frame, self.im is populated afresh.

Pillow/src/PIL/TiffImagePlugin.py

Lines 1189 to 1198 in 08d9c89

def seek(self, frame: int) -> None:

"""Select a given frame as current image"""

if not self._seek_check(frame):

return

self._seek(frame)

# Create a new core image object on second and

# subsequent frames in the image. Image may be

# different size/mode.

Image._decompression_bomb_check(self.size)

self.im = Image.core.new(self.mode, self.size)

Yeah, I saw this and tried to remove this initialization and relay on load_prepare instead, for some reasons it didn't work.

For me providing correct canvas (self.im) in the base class is more preferable than recreating it in the plugin. There was another approach which doesn't introduce difference between im.size and im._size.

Ah, I see now - my load_prepare() would create a new core image when the image was loaded after seek().

I've pushed a commit following your other approach.

src/PIL/TiffImagePlugin.py

Co-authored-by: Alexander Karpinsky <[email protected]>

radarhere added 2 commits September 18, 2024 20:26

Use transposed size after opening for TIFF images

f1e8696

Loading does not change mode

84e275d

radarhere mentioned this pull request Sep 18, 2024

TIFF: report correct image size after opening #8387

Closed

radarhere added the TIFF label Sep 18, 2024

homm reviewed Sep 18, 2024

View reviewed changes

radarhere and others added 2 commits September 18, 2024 21:17

Rearranged code

a859695

Co-authored-by: Alexander Karpinsky <[email protected]>

Use raw size for striped tiles

a92dca6

radarhere force-pushed the tiff_exif_transpose branch 2 times, most recently from 3ab41ec to a92dca6 Compare September 18, 2024 12:47

In seek(), create core image at size needed for loading

629f5be

homm approved these changes Sep 18, 2024

View reviewed changes

hugovk merged commit 1ee3bd1 into python-pillow:main Sep 18, 2024
50 checks passed

radarhere deleted the tiff_exif_transpose branch September 18, 2024 22:36

radarhere mentioned this pull request Sep 19, 2024

Use ImagingCore.ptr instead of ImagingCore.id #8341

Merged

hugovk mentioned this pull request Oct 5, 2024

Random crashes of python in latest dev version of Pillow with pillow_heif #8439

Closed

radarhere mentioned this pull request Oct 8, 2024

In Image.Image.seek(), clear core image if mode or size has changed #8450

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use transposed size after opening for TIFF images #8390

Use transposed size after opening for TIFF images #8390

radarhere commented Sep 18, 2024

homm Sep 18, 2024 •

edited

Loading

radarhere Sep 18, 2024

homm Sep 18, 2024 •

edited

Loading

radarhere Sep 18, 2024

	def seek(self, frame: int) -> None:
	"""Select a given frame as current image"""
	if not self._seek_check(frame):
	return
	self._seek(frame)
	# Create a new core image object on second and
	# subsequent frames in the image. Image may be
	# different size/mode.
	Image._decompression_bomb_check(self.size)
	self.im = Image.core.new(self.mode, self.size)

Use transposed size after opening for TIFF images #8390

Use transposed size after opening for TIFF images #8390

Conversation

radarhere commented Sep 18, 2024

homm Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

radarhere Sep 18, 2024

Choose a reason for hiding this comment

homm Sep 18, 2024 • edited Loading

Choose a reason for hiding this comment

radarhere Sep 18, 2024

Choose a reason for hiding this comment

homm Sep 18, 2024 •

edited

Loading

homm Sep 18, 2024 •

edited

Loading